Add users by role to the champion dashboard#16
Merged
Conversation
jonkeane
commented
Jan 6, 2026
Comment on lines
+597
to
+601
| ui.div( | ||
| ui.div("Active Users by Role", class_="card-title"), | ||
| ui.output_ui("active_users_by_role"), | ||
| class_="content-card" | ||
| ), |
Contributor
Author
There was a problem hiding this comment.
It would be great if this actually was hidden if we got back 0s/nones in the data. But maybe that's optimizing for a state we don't ever really expect people to be in.
tdstein
approved these changes
Jan 7, 2026
extensions/champion-dashboard/app.py
Outdated
| return ui.tags.table( | ||
| ui.tags.thead(header_row), | ||
| ui.tags.tbody(*table_rows), | ||
| class_="oauth-association-table" |
There was a problem hiding this comment.
The class name here seems unrelated. Maybe the oauth-association-table needs to renamed since it's being reused?
Contributor
Author
There was a problem hiding this comment.
Yeah, absolutely. God catch, thanks!
mconflitti-pbc
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is what this looks like against my local connect (which only has one account right now, so isn't super exciting):