feat: publisher-command-center with otel wiring #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I had many of the same questions here as I did for #7 so I'll refrain from recreating each of them here. The tldr; how do we differentiate these from their standard version counterparts? I think we should be treating them as their own thing and not just a version bump in which case we should give them their own initial versions. |
Contributor
Author
|
@joshyam-k I addressed those issues on this one too — should be good for review now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the OTel-wired Publisher Command Center.
How do folks think we should make it clear how these extensions relate to the ones in the prod extensions repo? Currently, the Publisher Command Center is identical to the version in prod save for the OTel changes. Should the directory be named differently? Or should the README contain a note? Or is it better to leave them as-is so, say, they could be pulled over to the main repo?
Deployed on Dogfood here