Merged
Conversation
ssinnott
requested review from
bschwedler,
ianpittwood and
zachhannum
as code owners
bschwedler
reviewed
Mar 18, 2026
workbench-positron-init/template/Containerfile.ubuntu2404.jinja2
Outdated
Show resolved
Hide resolved
workbench-positron-init/template/Containerfile.ubuntu2404.jinja2
Outdated
Show resolved
Hide resolved
workbench-positron-init/template/Containerfile.ubuntu2404.jinja2
Outdated
Show resolved
Hide resolved
…inja2 from goss - Fix docs CDN path (release -> releases) - Derive positron-server and docs URLs from positron_version instead of hardcoding positron_url and positron_docs_version in bakery.yaml - Rename goss.yaml.jinja2 to goss.yaml (no Jinja2 templating needed) - Update goss test to match actual docs zip structure (no bundled/ subdir) - Re-render version directories
bschwedler
force-pushed
the
add-positron-init
branch
from
1002390 to
0183cca
Compare
Replace version-based config with a matrix using the new positron bakery dependency for automatic version discovery from the Posit CDN. - Use POSITRON_VERSION build arg instead of template values - Add TARGETARCH support for multi-platform builds, mapping Docker arch names to CDN path segments and artifact keys - Replace versioned directories (2026.02/, 2026.03/) with matrix/ subpath - Use CMD instead of ENTRYPOINT for positron-init
Use positron bakery dependency for init container
Contributor
|
LGTM. I will wait to approve/merge until the Docker Hub repository has been created. |
bschwedler
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ok this is a first take. Happy for feedback,
2026.03) do we need that here? I think it was created when I added each positron version intoversions- but I might be following the wrong pattern. Also would this end up changing if we're pulling these dynamically and plugging them in?