Fix gosec G118 false positive in streamStore.Start#6
Merged
dmortondev merged 1 commit intomainfrom Mar 7, 2026
Merged
Conversation
The cancel function is stored in the streamRecord struct and called in Cancel(). Suppress the lint warning with a nolint directive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
//nolint:gosecdirective tostreamStore.Start()wherecontext.WithCancelcancel func is stored in a struct field and called later inCancel()Context
CI uses
version: latestfor golangci-lint. A new upstream release introduced the G118 rule (context cancellation function not called) between when PR #5 was checked and when its merge commit was checked on main. This is a false positive — the cancel function is stored instreamRecord.Canceland invoked instreamStore.Cancel().Test plan
just lintpasses locally with golangci-lint v2.11.1