Skip to content

Conversation

@rich-iannone
Copy link
Member

This PR is a fix for the unbounded collection of extract rows. There was a limit arg in interrogate() but it only applied to extracts collected via sampling (not the default). This change ensures that the limit is applied universally.

Fixes: #129

@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.04%. Comparing base (871cd9a) to head (2ed5dde).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #130   +/-   ##
=======================================
  Coverage   99.04%   99.04%           
=======================================
  Files          17       17           
  Lines        3651     3651           
=======================================
  Hits         3616     3616           
  Misses         35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rich-iannone rich-iannone marked this pull request as ready for review March 28, 2025 21:10
@rich-iannone rich-iannone merged commit ee5afeb into main Mar 28, 2025
5 checks passed
@rich-iannone rich-iannone deleted the fix-set-limit-extracts branch March 28, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

get_tabular_report takes too long on already interrogated validation graphs

3 participants