Add experimental gradual typing for development#198
Add experimental gradual typing for development#198rich-iannone merged 13 commits intoposit-dev:mainfrom
Conversation
|
Also I think we should leave this branch open, it's easy for me to come in and gradually type a few things and push. |
|
This is so great, ty! |
|
No worries! Whenever you want to merge feel free, I'm just going to keep pushing stuff |
|
Do you want to merge these periodically? i don't think i'll be able to get all of this in one shot |
|
@tylerriccio33 Could you update this branch with the current |
I missed a merge marker resulting in a huge diff.
|
Ok this should all be good. Missed a merge marker in test_validate.py so had to do some gymnastics to get back in sync. |
tylerriccio33
force-pushed
the
typing
branch
from
f3dcfe6 to
227d176
Compare
|
@rich-iannone if possible I'd really appreciate it if you could review and merge so i can continue making things type safe. I think if this doesn't get merged I'd have to close and start over since it's really tough to keep up with main. Let me know what you think :) |
|
Thank you so much @tylerriccio33 for all the work you’ve done on this! I’ll review shortly (in the next 2 hours). |
|
Thanks mate, let me know if you have any Qs! I think this is going to make the dev experience and correctness much better |
|
Awesome! I'll keep contributing to this, i'll tag you if I feel like it's at a place where it can be merged again! |
2 participants
This PR adds a little support and considerations for local/dev type checking. I add ty (astral's new experimental type checker) to the makefile, add pointblank/py.typed to the ignore file and updated the documentation to say you can type check but it's not enforced. I think as time goes on, I'll start gradually typing things, and maybe one day it can get into the CI checks. For now, this is just helpful for development, especially if you're so used to relying on a type checker (i am).
Also, random but I found pytest-xdist was repeated in the dependencies so i removed it.