Ignore more things and fix remaining lints

Author: schloerke

examples/connect/databricks/dash/app.py

@@ -38,7 +38,8 @@ def update_page(_):
     """
     session_token = flask.request.headers.get("Posit-Connect-User-Session-Token")
     posit_strategy = PositCredentialsStrategy(
-        local_strategy=databricks_cli, user_session_token=session_token,
+        local_strategy=databricks_cli,
+        user_session_token=session_token,
     )
     cfg = Config(
         host=DATABRICKS_HOST_URL,

examples/connect/databricks/flask/app.py

@@ -31,7 +31,8 @@ def get_fares():
 
     session_token = request.headers.get("Posit-Connect-User-Session-Token")
     posit_strategy = PositCredentialsStrategy(
-        local_strategy=databricks_cli, user_session_token=session_token,
+        local_strategy=databricks_cli,
+        user_session_token=session_token,
     )
     cfg = Config(
         host=DATABRICKS_HOST_URL,

examples/connect/databricks/shiny/app.py

@@ -24,7 +24,8 @@ def server(i: Inputs, o: Outputs, session: Session):
     """
     session_token = session.http_conn.headers.get("Posit-Connect-User-Session-Token")
     posit_strategy = PositCredentialsStrategy(
-        local_strategy=databricks_cli, user_session_token=session_token,
+        local_strategy=databricks_cli,
+        user_session_token=session_token,
     )
     cfg = Config(
         host=DATABRICKS_HOST_URL,

examples/connect/databricks/streamlit/app.py

@@ -16,7 +16,8 @@
 
 session_token = st.context.headers.get("Posit-Connect-User-Session-Token")
 posit_strategy = PositCredentialsStrategy(
-    local_strategy=databricks_cli, user_session_token=session_token,
+    local_strategy=databricks_cli,
+    user_session_token=session_token,
 )
 cfg = Config(
     host=DATABRICKS_HOST_URL,

integration/tests/posit/connect/test_users.py

@@ -6,13 +6,19 @@ class TestUser:
     def setup_class(cls):
         cls.client = client = connect.Client()
         cls.aron = client.users.create(
-            username="aron", email="[email protected]", password="s3cur3p@ssword",
+            username="aron",
+            email="[email protected]",
+            password="s3cur3p@ssword",
         )
         cls.bill = client.users.create(
-            username="bill", email="[email protected]", password="s3cur3p@ssword",
+            username="bill",
+            email="[email protected]",
+            password="s3cur3p@ssword",
         )
         cls.cole = client.users.create(
-            username="cole", email="[email protected]", password="s3cur3p@ssword",
+            username="cole",
+            email="[email protected]",
+            password="s3cur3p@ssword",
         )
 
     def test_lock(self):
@@ -71,7 +77,9 @@ def test_find_one(self):
 
     def test_multiple_users(self):
         user = self.client.users.create(
-            username="example", email="[email protected]", password="s3cur3p@ssword",
+            username="example",
+            email="[email protected]",
+            password="s3cur3p@ssword",
         )
         # assert filtering limits to the provided user.
         assert self.me.content.find_one() == self.content

pyproject.toml

@@ -45,10 +45,13 @@ docstring-code-line-length = "dynamic"
 
 [tool.ruff.lint]
 extend-ignore = [
-    "E501",  # E501: Line too long
-    "PT011", # PT011 `pytest.raises(ValueError)` is too broad
-    "PT022", # PT022 [*] No teardown in fixture
-    "F841",  # F841 Local variable is assigned but never used
+    "E501",   # Line too long
+    "PT011",  # `pytest.raises(ValueError)` is too broad
+    "PT022",  # No teardown in fixture
+    "F841",   # Local variable is assigned but never used
+    "COM812", # missing-trailing-comma
+    "ISC001", # single-line-implicit-string-concatenation
+    "ISC002", # multi-line-implicit-string-concatenation
 ]
 extend-select = [
     # "C90", # Many false positives # C90; mccabe: https://docs.astral.sh/ruff/rules/complex-structure/

src/posit/connect/vanities.py

@@ -185,7 +185,9 @@ def vanity(self) -> None:
         --------
         reset_vanity
         """
-        self.vanity
+        # Populate value
+        self.vanity  # noqa: B018
+
         if self._vanity:
             self._vanity.destroy()
         self.reset_vanity()

tests/posit/connect/test_bundles.py

@@ -144,7 +144,7 @@ def test(self):
         task = bundle.deploy()
 
         # assert
-        task.id == task_id
+        assert task.id == task_id
         assert mock_content_get.call_count == 1
         assert mock_bundle_get.call_count == 1
         assert mock_bundle_deploy.call_count == 1

tests/posit/connect/test_client.py

@@ -135,7 +135,8 @@ def test_request(self, MockSession):
         client = Client(api_key=api_key, url=url)
         client.request("GET", "/foo")
         MockSession.return_value.request.assert_called_once_with(
-            "GET", "https://connect.example.com/__api__/foo",
+            "GET",
+            "https://connect.example.com/__api__/foo",
         )
 
     def test_get(self, MockSession):
@@ -180,5 +181,7 @@ def test_required_version(self):
         url = "https://connect.example.com"
         client = Client(api_key=api_key, url=url)
         client.ctx.version = "2024.07.0"
+        oauth = None
         with pytest.raises(RuntimeError):
-            client.oauth
+            oauth = client.oauth
+        assert oauth is not None

tests/posit/connect/test_content.py

@@ -88,7 +88,7 @@ def test(self):
         task = content.deploy()
 
         # assert
-        task.id == task_id
+        assert task.id == task_id
         assert mock_content_get.call_count == 1
         assert mock_content_deploy.call_count == 1
         assert mock_tasks_get.call_count == 1