feat: add jobs #314
Merged
feat: add jobs #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
toph-allen
approved these changes
Oct 24, 2024
Collaborator
toph-allen
left a comment
toph-allen
left a comment
There was a problem hiding this comment.
This generally looks good — but approving with the caveat that I don't feel like I fully grok some of the mechanisms at play here. Would be great to walk through the PR together so I can ask questions.
tdstein
commented
Oct 24, 2024
schloerke
reviewed
Oct 24, 2024
Collaborator
Author
|
@toph-allen and I met over Zoom to discuss his questions and talk about the code in more depth. Please let me know if anyone else would like to do the same. Happy to do so. |
schloerke
reviewed
Oct 24, 2024
zackverham
reviewed
Oct 25, 2024
zackverham
reviewed
Oct 25, 2024
zackverham
reviewed
Oct 25, 2024
schloerke
reviewed
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds job support.
The mixin pattern is continued, and a 'jobs' property is added to
ContentItem.A new abstraction around resources called
Activeis introduced. This abstraction begins a transition to a more idiomatic approach to interacting with collections. Similar to how printing aResourceshows adict, theActiveSequenceshows a familiarList[dict]representation. TheActiveFinderMethodssupports thefindandfind_bymethods. This is inspired by this Ruby on Rails module https://api.rubyonrails.org/classes/ActiveRecord/FinderMethods.html. Ideally, this separation of concerns provides a straightforward way to compose bindings in the future and reduces the amount of duplication across implementations.Additional background may be found here https://github.com/tdstein/active
Related to #310
Resolves #306