-
Notifications
You must be signed in to change notification settings - Fork 8
build: Embrace ruff #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
build: Embrace ruff #319
Changes from 3 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
e6b62a3
Add ruff as suggested extension
schloerke 91b2b67
Nice to have settings
schloerke 4123113
Disable isort and black in case extensions run on save
schloerke 3a627e0
Update .vscode/settings.json
schloerke 21b2360
Copy in rules from old shiny PR
schloerke 6180330
auto fixes
schloerke 52cbd8d
Autofix some failures
schloerke db6916f
More exclusions and fixes
schloerke 48c8857
Ignore more things and fix remaining lints
schloerke 504d5c9
Merge branch 'require_ruff_on_save' of https://github.com/posit-dev/p…
schloerke 44bbe1b
Work around check
schloerke e4eb646
Update test_client.py
schloerke 3a5226e
Do not use mock error class as it can not be caught
schloerke c3f8dbf
Fix unsafe change to revert never ending test
schloerke 4501ace
Merge branch 'main' into require_ruff_on_save
schloerke 1a808f0
Update test_hooks.py
schloerke c869062
Use `HTTPError` and not `Exception`
schloerke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { | ||
| "recommendations": [ | ||
| "charliermarsh.ruff" | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,25 @@ | ||
| { | ||
| "files.trimTrailingWhitespace": true, | ||
| "files.insertFinalNewline": true, | ||
| "editor.tabSize": 2, | ||
| "files.encoding": "utf8", | ||
| "files.eol": "\n", | ||
| "python.testing.pytestArgs": [ | ||
| "tests" | ||
| ], | ||
| "python.testing.unittestEnabled": false, | ||
| "python.testing.pytestEnabled": true, | ||
| "[python]": { | ||
| "editor.defaultFormatter": "charliermarsh.ruff", | ||
| "editor.formatOnSave": true, | ||
| "editor.tabSize": 4, | ||
| "editor.codeActionsOnSave": { | ||
| "source.organizeImports": "explicit" | ||
| } | ||
| }, | ||
| "files.exclude": { | ||
| "**/__pycache__": true, | ||
| "build/**": true | ||
| }, | ||
| "editor.rulers": [99], | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.