refactor: removes cache layer from active sequence #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Collaborator
Author
|
Made |
tdstein
force-pushed
the
tdstein/no-cache
branch
from
01da449 to
0360b6a
Compare
schloerke
approved these changes
Nov 4, 2024
Collaborator
schloerke
left a comment
schloerke
left a comment
There was a problem hiding this comment.
I'd like to explore more of possibly removing the caching layer completely in a followup.
But I like where this is going!
schloerke
added a commit
that referenced
this pull request
Nov 4, 2024
* main: refactor: removes cache layer from active sequence (#320)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the cache layer from finder methods to reduce the complexity of propagating query parameters.
When passing query parameters through finder methods, it is difficult to manage the cache if we wish to have it reflect the user's query state. For example, when calling
packages.find_by(name='posit-sdk)',what shouldpackages._datareturn on the next call?