feat: add environments #353
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
tdstein
force-pushed
the
tdstein/307-environments
branch
from
3391873 to
eddfc31
Compare
tdstein
force-pushed
the
tdstein/307-environments
branch
from
f552fe2 to
2942856
Compare
schloerke
reviewed
Dec 12, 2024
| endpoint = self._ctx.url + self._path | ||
| response = self._ctx.session.put(endpoint, json=attributes) | ||
| result = response.json() | ||
| super().update(**result) |
Collaborator
There was a problem hiding this comment.
Would we like for this method to return a new definition of self?
Something like
Suggested change
| super().update(**result) | |
| return self.__class__(**result) |
This sets up an easy transition to a read only self.
Collaborator
There was a problem hiding this comment.
I'm ok with keeping the .update() as is. I'd like to make a followup PR to revert Task.update and ContentItemRepository.update
Comment on lines
+43
to
+57
| id: str, | ||
| guid: str, | ||
| created_time: str, | ||
| updated_time: str, | ||
| title: str, | ||
| name: str, | ||
| description: str | None, | ||
| cluster_name: str | Literal["Kubernetes"], | ||
| environment_type: str | Literal["Kubernetes"], | ||
| matching: Literal["any", "exact", "none"], | ||
| supervisor: str | None, | ||
| python: _Installations | None, | ||
| quarto: _Installations | None, | ||
| r: _Installations | None, | ||
| tensorflow: _Installations | None, |
Collaborator
There was a problem hiding this comment.
Should these variables be Unpack[_Attrs] so that if typing isn't followed 100% there is some sort of type check?
Something like:
def __init__(self, ctx: Context, path: str, /, **attributes: Unpack[_Attrs]):
Collaborator
There was a problem hiding this comment.
Same applies to .update(), .create(), and .find_by() below
Collaborator
Author
|
Closing in favor of #355 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds environment support.
The create, update, and destroy methods are abstracted in the resources module as base classes. This alleviates potential duplication across API bindings. Future changes should utilize these classes instead of reimplementing these methods from scratch.
Closes #307