refactor: Leverage Context's Client to make requests #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Collaborator
Thank you! |
tdstein
approved these changes
Dec 13, 2024
Collaborator
tdstein
left a comment
tdstein
left a comment
There was a problem hiding this comment.
🙌🏻 🙌🏻 🙌🏻 Nice net deletion!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original request: #352 (review)
I like it. So I updated as many as I could where I didn't have to guess at the intent.
Sessionsis still used by other classes that use.params.Given all
Paginatorinstances could use context, I switched those as well.