feat: add base protocols for Resource and ResourceSequence #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
tdstein
force-pushed
the
tdstein/better-protocols
branch
from
93e75eb to
8eb0486
Compare
schloerke
approved these changes
Dec 16, 2024
Comment on lines
+91
to
+94
| T = TypeVar("T", bound=Resource) | ||
|
|
||
|
|
||
| class ResourceSequence(Protocol[T]): |
schloerke
reviewed
Dec 16, 2024
| def __getitem__(self, key: Hashable) -> Any: ... | ||
|
|
||
|
|
||
| class _Resource(dict, Resource): |
Collaborator
There was a problem hiding this comment.
This class is no longer needed, right?
Or maybe the methods of _Resource and BaseResource need to be merged?
Collaborator
Author
There was a problem hiding this comment.
Correct. The BaseResource class should go away. But that likely requires finishing the migration to the new implicit subtyping pattern. Which I am planning to complete.
schloerke
reviewed
Dec 16, 2024
schloerke
added a commit
that referenced
this pull request
Dec 16, 2024
Co-authored-by: Barret Schloerke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.