Skip to content

test: add v2024.12.0 and v2025.01.0 to integration test suite #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 14, 2025
Merged

test: add v2024.12.0 and v2025.01.0 to integration test suite #383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
096cd4f
test: add v2024.12.0 and v2025.01.0 to integration test suite
tdstein Feb 14, 2025
cdd5195
fix: linting error
tdstein Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ jobs:
matrix:
CONNECT_VERSION:
- preview
- 2025.01.0
- 2024.12.0
- 2024.11.0
- 2024.09.0
- 2024.08.0
Expand Down
7 changes: 4 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ include vars.mk

.PHONY: build clean cov default dev docker-deps docs ensure-uv fmt fix install it lint test uninstall version help

$(UV_LOCK): dev
$(UV) lock

all: dev test lint build

build: dev
Expand All @@ -30,7 +33,7 @@ cov-xml: dev
$(UV) run coverage xml

dev: ensure-uv
$(UV) pip install -e .
$(UV) pip install --upgrade -e .

docker-deps: ensure-uv
# Sync given the `uv.lock` file
Expand Down Expand Up @@ -59,8 +62,6 @@ fmt: dev
install: build
$(UV) pip install dist/*.whl

$(UV_LOCK): dev
$(UV) lock
it: $(UV_LOCK)
$(MAKE) -C ./integration

Expand Down
2 changes: 2 additions & 0 deletions integration/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ PYTEST_ARGS ?= "-s"

# Versions
CONNECT_VERSIONS := \
2025.01.0 \
2024.12.0 \
2024.11.0 \
2024.09.0 \
2024.08.0 \
Expand Down
6 changes: 5 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,11 @@ classifiers = [
"Typing :: Typed",
]
dynamic = ["version"]
dependencies = ["requests>=2.31.0,<3", "packaging", "typing-extensions"]
dependencies = [
"requests>=2.31.0,<3",
"packaging",
"typing-extensions",
]

[project.urls]
Source = "https://github.com/posit-dev/posit-sdk-py"
Expand Down
5 changes: 3 additions & 2 deletions src/posit/connect/system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,8 @@ def destroy(
version: str,
image_name: str,
dry_run: Literal[False] = False,
) -> Task: ...
) -> Task | None: ...

@overload
def destroy(
self,
Expand All @@ -211,7 +212,7 @@ def destroy(
version: str,
image_name: str,
dry_run: Literal[True] = True,
) -> None: ...
) -> Task | None: ...

def destroy(
self,
Expand Down