fix issues with copilot chat compatibility in positron#13
Closed
sharon-wang wants to merge 2 commits intomainfrom
Closed
fix issues with copilot chat compatibility in positron#13sharon-wang wants to merge 2 commits intomainfrom
sharon-wang wants to merge 2 commits intomainfrom
Conversation
Remove `chatHooks@1` and unversion `chatParticipantAdditions@1` in enabledApiProposals to fix extension validation failures in Positron release/daily builds. `chatHooks` does not exist in Positron's CodeOSS 1.109 base, and `chatParticipantAdditions` is defined without a version number. The versioned proposals were added in upstream v0.38 possibly targeting a pre-release VS Code build. Both can be resolved with the 1.110 merge.
Maybe an upstream merge oopsie since it's imported in the upstream code https://github.com/microsoft/vscode-copilot-chat/blob/c1a560a0acfa28a500d9f74e8fd8406b564ed037/src/extension/tools/vscode-node/toolsService.ts#L10
This was referenced Mar 11, 2026
Member
Author
|
Superseded by #15! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing copilot chat extension
The chat extension is missing because it is incompatible with the APIs in Positron. See these error messages in the devtools:
To resolve this, I:
chatHooks@1and unversionedchatParticipantAdditions@1in enabledApiProposalschatHooksdoes not exist in Positron's CodeOSS 1.109 base, andchatParticipantAdditionsis defined without a version number. The versioned proposals were added in upstream v0.38 possibly targeting a pre-release VS Code build which is not quite compatible with our 1.109-based Positron APIsMissing Iterable import
After the above change, sending a message in chat with a github copilot model resulted in an
Iterable is not definederror, but the fix was just to import it!Iterable is not defined
The import exists upstream so I think maybe just an upstream merge oopsie: https://github.com/microsoft/vscode-copilot-chat/blob/v0.38.2026020408/src/extension/tools/vscode-node/toolsService.ts#L10
More errors
After adding the import above, still getting errors:
Cannot read properties of undefined (reading 'bind')
I think we should either go back to 0.37 of the copilot chat extension, or wait till we merge the copilot chat extension from upstream for 1.110 of upstream Code OSS.