Skip to content

user interface page#95

Merged
rodrigosf672 merged 19 commits intomainfrom
rsf/user-interface
Jul 11, 2025
Merged

user interface page#95
rodrigosf672 merged 19 commits intomainfrom
rsf/user-interface

Conversation

@rodrigosf672
Copy link
Copy Markdown
Member

@rodrigosf672 rodrigosf672 commented Jun 23, 2025

Partially addresses #7541 by adding docs for the command palette.

Based on initial feedback from @jthomasmock and @juliasilge, I have made some changes and put together as a .qmd file to suit the requirements for documentations. It's my first time opening a PR in this repo, so please reach out in case I'm missing any standards/processes. Thanks!

@netlify
Copy link
Copy Markdown

netlify bot commented Jun 23, 2025

Deploy Preview for positron-posit-co ready!

Name Link
🔨 Latest commit 250e6cf
🔍 Latest deploy log https://app.netlify.com/projects/positron-posit-co/deploys/68715250dc27870008d4bdb3
😎 Deploy Preview https://deploy-preview-95--positron-posit-co.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@rodrigosf672
Copy link
Copy Markdown
Member Author

rodrigosf672 commented Jun 23, 2025

FYI I'm installing vale and resolving the linting issues that came up.

Copy link
Copy Markdown
Collaborator

@juliasilge juliasilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for working on these important docs, @rodrigosf672! 🙌

rodrigosf672 and others added 2 commits June 24, 2025 17:25
Co-authored-by: Julia Silge <julia.silge@gmail.com>
…plicable

Co-authored-by: Julia Silge <julia.silge@gmail.com>
Copy link
Copy Markdown
Contributor

@jthomasmock jthomasmock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting this! I have a few comments inline, happy to sync up or work async here if you have any questions.

@dhruvisompura dhruvisompura mentioned this pull request Jul 1, 2025
@rodrigosf672
Copy link
Copy Markdown
Member Author

@dhruvisompura The git conflicts I had have been resolved. Please let me know if you have any thoughts or additional feedback.

For the main figure, please note that this will be changed to showcase a figure that has active plots and variables panes, which make it more interesting/compelling.

@dhruvisompura dhruvisompura self-requested a review July 2, 2025 20:49
@juliasilge
Copy link
Copy Markdown
Collaborator

I added the same screenshot that @jennybc has in #116 as a temporary option for now. I'll open a followup issue to make a nice Python one for this page, similar to what we have here.

@juliasilge juliasilge requested a review from dhruvisompura July 10, 2025 23:36
juliasilge
juliasilge previously approved these changes Jul 10, 2025
Copy link
Copy Markdown
Collaborator

@juliasilge juliasilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this work, @rodrigosf672! I took a stab at some editing based on feedback we've gotten on what folks want to see here.

@juliasilge juliasilge dismissed jthomasmock’s stale review July 10, 2025 23:37

Dismissing the old review so we can move forward with merging!

Co-authored-by: Dhruvi Sompura <dhruvi.sompura@posit.co>
@juliasilge juliasilge requested a review from dhruvisompura July 11, 2025 18:08
@rodrigosf672 rodrigosf672 merged commit a0f033c into main Jul 11, 2025
5 of 6 checks passed
@rodrigosf672 rodrigosf672 deleted the rsf/user-interface branch July 11, 2025 21:15
@rodrigosf672
Copy link
Copy Markdown
Member Author

Thanks everyone involved in this team effort. I really appreciated all the support, feedback, and changes. Thanks @jthomasmock @juliasilge @dhruvisompura @testlabauto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants