update data explorer column selector to use new search #10004
Merged
+247
−184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename function to match summary panel instance
The layout manager and cache need to stay in sync so that indices match up.
|
E2E Tests 🚀 |
dhruvisompura
force-pushed
the
feature/update-data-explorer-column-selector
branch
from
32b35fe to
9c5ffeb
Compare
softwarenerd
previously approved these changes
Oct 20, 2025
...rerPanel/components/addEditRowFilterModalPopup/components/columnSelectorDataGridInstance.tsx
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| // Get the column schema for the row index. | ||
| // Get the column schema for the data at this row index. |
There was a problem hiding this comment.
There's no data. data at this seems weird to me.
isabelizimm
previously approved these changes
Oct 20, 2025
dhruvisompura
dismissed stale reviews from isabelizimm and softwarenerd
via
f94ec09
dhruvisompura
deleted the
feature/update-data-explorer-column-selector
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #9847
Updates the column selector modal popup (which is a data grid under the hood) to use the new backend search functionality we added to the data explorer.
This should address the issue we were seeing where column names weren't rendering in the drop down when the number of columns was greater than a few hundred. Instead of trying to fetch and render all columns, only the columns that are visible are shown and cached. When the user scrolls or searches, we go out and fetch the column data that should be in view. This is the same behavior we have in the other data grids, like the summary panel.
Note: The RPC timeout issue described in #9846 is now also present in the column selector modal popup when searching if there are a large number of columns present. Searching will silently fail if it takes longer than 5 seconds. Depsite this, the behavior is much improved than what it was previously.
For keyboard functionality testing, I want to point out the focus and keyboard behavior when using the search in the filter column selector dropdown is slightly different than a traditional dropdown because of some of the custom cursor selection behavior we have. The biggest thing to be aware of is: the focus/selected styling in the dropdown is always visible (and set to the first item in the dropdown) when a search is active. This is a bit odd when searching because the actual focus indicator is in the search box. Pressing
Arrow DownorTabwill move the actual focus indicator into the dropdown but its not obvious that is where focus went since the selected/focused state for the dropdown is always present and there is no difference between focus and selection. Everything works, its just a bit odd visually. This is how its always worked and hasn't been changed in this PR! Just be aware when testing.Here's an example of an accessible combobox pattern in case you are curious what the differences are: https://www.w3.org/WAI/ARIA/apg/patterns/combobox/examples/combobox-autocomplete-both/
BEFORE - 5 million columns
Screen.Recording.2025-10-17.at.10.05.46.AM.mov
AFTER - Dropdown without search (6 columns)
Screen.Recording.2025-10-16.at.3.30.23.PM.mov
AFTER - Dropdown with search (1000 columns)
Screen.Recording.2025-10-17.at.10.09.36.AM.mov
AFTER - Dropdown with search (5 million columns)
Screen.Recording.2025-10-17.at.10.04.17.AM.mov
Release Notes
New Features
Bug Fixes
QA Notes
@:data-explorer
@:web
@:win