remote ssh: add custom serverInstallPath setting #10017
Open
+16
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
austin3dickey
commented
Oct 17, 2025
|
|
||
| let commandOutput: { stdout: string; stderr: string }; | ||
| if (platform === 'windows') { | ||
| // If the default was not changed, adjust the path for PowerShell on Windows |
There was a problem hiding this comment.
We don't support windows anyway
isabelizimm
approved these changes
Oct 20, 2025
| const productJson = await getVSCodeProductJson(); | ||
|
|
||
| const customServerBinaryName = vscode.workspace.getConfiguration('remoteSSH.experimental').get<string>('serverBinaryName', ''); | ||
| const customDataFolderName = vscode.workspace.getConfiguration('remoteSSH').get<string>('serverInstallPath', ''); |
There was a problem hiding this comment.
SUPER SUPER nit, could set default here rather than later
Suggested change
| const customDataFolderName = vscode.workspace.getConfiguration('remoteSSH').get<string>('serverInstallPath', ''); | |
| const serverDataFolderName = vscode.workspace.getConfiguration('remoteSSH').get<string>('serverInstallPath', productJson.serverDataFolderName); |
jmcphers
requested changes
Oct 20, 2025
There was a problem hiding this comment.
I think this needs just a few more tweaks:
- it is pretty easy to just type something like
.positron-server-2into the setting if you aren't reading carefully, and the behavior is undefined in this case. If the user doesn't specify an absolute path, I think we should resolve the relative path against$HOMEby default - the setting is application scoped but this feels more like a per project/machine thing b/c you probably won't have the same needs for everything you connect to. maybe change the scope? another idea would be to make the value something you can override with an env var so it could be configured on the host side
- if the user specifies a path that they can't write to and we can't make for them, what happens? (think we need better error handling for this than we have today)
- do we actually expand tildes in the setting value? (wasn't clear to me but the default uses
$HOME; if not, the example shouldn't use them)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #9013. Adds a
remoteSSH.serverInstallPathsetting that lets you customize the Positron server data directory, instead of the default~/.positron-server.Release Notes
New Features
remoteSSH.serverInstallPathsetting lets you customize the directory for the Positron server Provide custompositron-serverinstall path? #9013Bug Fixes
QA Notes
The new setting should be respected. To test on this branch, you'll unfortunately need to build REH on the remote host and put it where it needs to be. It'll be easier to test on a daily build.