Skip to content

assistant: handle empty input_schema for vercel providers flow #10021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2025
+13 −2
Merged

assistant: handle empty input_schema for vercel providers flow #10021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84cfd88
assistant: handle empty input_schema for vercel providers flow
sharon-wang Oct 17, 2025
c51e9c8
match anthropic log message
sharon-wang Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion extensions/positron-assistant/src/anthropic.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,11 +589,12 @@ function toAnthropicTools(tools: readonly vscode.LanguageModelChatTool[]): Anthr
}

function toAnthropicTool(tool: vscode.LanguageModelChatTool): Anthropic.ToolUnion {
// Anthropic requires a type for all tools; default to 'object' if not provided.
// See similar handling for the vercel SDK in AILanguageModel provideLanguageModelChatResponse in extensions/positron-assistant/src/models.ts
const input_schema = tool.inputSchema as Anthropic.Tool.InputSchema ?? {
type: 'object',
properties: {},
};
// Anthropic requires a type for all tools; default to 'object' if not provided.
if (!input_schema.type) {
log.warn(`[anthropic] Tool '${tool.name}' is missing input schema type; defaulting to 'object'`);
input_schema.type = 'object';
Expand Down
12 changes: 11 additions & 1 deletion extensions/positron-assistant/src/models.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,9 +442,19 @@ abstract class AILanguageModel implements positron.ai.LanguageModelChatProvider

if (options.tools && options.tools.length > 0) {
tools = options.tools.reduce((acc: Record<string, ai.Tool>, tool: vscode.LanguageModelChatTool) => {
// Some providers like AWS Bedrock require a type for all tool input schemas; default to 'object' if not provided.
// See similar handling for Anthropic in toAnthropicTool in extensions/positron-assistant/src/anthropic.ts
const input_schema = tool.inputSchema as Record<string, any> ?? {
type: 'object',
properties: {},
};
if (!input_schema.type) {
log.warn(`Tool '${tool.name}' is missing input schema type; defaulting to 'object'`);
input_schema.type = 'object';
}
acc[tool.name] = ai.tool({
description: tool.description,
parameters: ai.jsonSchema(tool.inputSchema ?? { type: 'object', properties: {} }),
parameters: ai.jsonSchema(input_schema),
});
return acc;
}, {});
Expand Down