Connections Pane: Support SQL Server #10824
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 |
dfalbel
force-pushed
the
connections/sqlserver
branch
from
f7b3f89 to
bc1efef
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds SQL Server support to the Connections Pane through both pyodbc and pymssql drivers. The implementation follows established patterns from other database connections (Snowflake, BigQuery, Databricks) and includes comprehensive test coverage.
Key Changes
- Implemented
SQLServerConnectionclass with support for both pyodbc and pymssql drivers - Added helper function
_is_pyodbc_sqlserver()to detect SQL Server connections via pyodbc - Created comprehensive test suite with base test class and driver-specific implementations
- Added package dependencies for pymssql and pyodbc to test requirements
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
connections.py |
Added SQLServerConnection class implementing database/schema/table hierarchy navigation, field listing, and preview functionality with proper SQL identifier escaping |
test_connections.py |
Added test infrastructure including connection helper functions, base test class _SQLServerConnectionsTestBase, and two driver-specific test classes |
pinned-test-requirements.txt |
Added pymssql==2.3.10 and pyodbc==5.3.0 with Python version constraints |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
extensions/positron-python/python_files/posit/positron/tests/test_connections.py
Show resolved
Hide resolved
extensions/positron-python/python_files/posit/positron/tests/test_connections.py
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]> Signed-off-by: Daniel Falbel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #10433
Support for MSSqlServer trough pyodbc and pymssql
Release Notes
New Features
Bug Fixes
QA Notes