e2e test - pyrefly basic completion suggestion #10846
Conversation
|
E2E Tests 🚀 |
There was a problem hiding this comment.
Pull request overview
This PR adds two new e2e test suites to validate LSP functionality and data visualization:
- LSP Pyrefly Integration: Introduces a basic completion suggestion test to verify Pyrefly language server functionality with untitled Python files, specifically to assess CI stability under CPU usage
- Data Explorer Histogram Rounding: Comprehensive test suite validating histogram bin range formatting and precision across various numeric scales
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/e2e/tests/extensions/lsp-pyrefly.test.ts | New test file for basic Pyrefly completion suggestions in untitled Python files |
| test/e2e/tests/data-explorer/histogram-rounding.test.ts | New test suite validating histogram bin rounding and display precision across 4 numeric scale scenarios |
| await app.workbench.clipboard.paste(); | ||
| await app.workbench.editors.expectEditorToContain('import math'); | ||
| await app.code.driver.page.keyboard.press('Control+Space'); | ||
| await expect(app.code.driver.page.locator('.suggest-widget')).toBeVisible(); |
There was a problem hiding this comment.
The test verifies the suggest widget appears but doesn't validate that completions are actually provided by Pyrefly. Consider adding an assertion to check that at least one completion item exists within the widget to ensure the LSP server is functioning correctly.
| await hotKeys.closeAllEditors(); | ||
| }); | ||
|
|
||
| const hoverBinWithRange = async (page: any, expectedMin: string, expectedMax: string) => { |
There was a problem hiding this comment.
The parameter 'page' should be typed with the proper Playwright Page type instead of 'any' for better type safety and IntelliSense support.
@:pyrefly?QA Notes
@:web @:win @:extensions @:editor