Skip to content

Conversation

@rodrigosf672
Copy link
Member

@rodrigosf672 rodrigosf672 commented Dec 2, 2025

Adds a test step to confirm that Clear Current URL removes the active iframe and resets the Viewer.

Why test.step()

  • Keeping it inside the existing Dash test avoids extra setup and follows the same pattern as other Viewer checks (e.g., open-in-editor).
  • It fits cleanly into the app’s lifecycle without creating new tests (less time spent running tests).
  • Note that the step is placed in the end of the test. Changing the order of steps in the future could lead to failure of other steps.

Why only in the Dash app

  • The feature is Viewer-specific, not app-specific, so duplicating it across other Python apps offers no extra coverage.
  • Dash is the simplest, most stable example, and its clear “Hello World” render allows the test to reliably assert the iframe to no-iframe state transition (from occupied iframe to div-content emptiness).
  • If test.step() fails in the future, the presence of "Hello World" would be a clear indicator to look at the screenshots.

QA Notes

@:apps @:viewer @:editor @:web

@github-actions
Copy link

github-actions bot commented Dec 2, 2025

E2E Tests 🚀
This PR will run tests tagged with: @:critical @:apps @:viewer @:editor @:web

readme  valid tags

@rodrigosf672 rodrigosf672 changed the title e2e test - clear current url e2e test - "Clear the current URL" button clears the Viewer pane Dec 2, 2025
@rodrigosf672 rodrigosf672 linked an issue Dec 2, 2025 that may be closed by this pull request
testlabauto
testlabauto previously approved these changes Dec 3, 2025
Copy link
Contributor

@testlabauto testlabauto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@testlabauto testlabauto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why its not passing?

Signed-off-by: Rodrigo Silva Ferreira <[email protected]>
Signed-off-by: Rodrigo Silva Ferreira <[email protected]>
Signed-off-by: Rodrigo Silva Ferreira <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automated test to verify 'Clear the current URL' works

3 participants