Fix cleanup of R sessions #10933
Open
Fix cleanup of R sessions #10933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 |
lionel-
force-pushed
the
task/r-session-cleanup
branch
from
4ebf876 to
baf0589
Compare
lionel-
commented
Dec 4, 2025
| const session = sessions.find(s => s.metadata.sessionId === sessionId); | ||
| if (!session) { | ||
| // The foreground session is for another language. | ||
| // The foreground session is for another language or was deactivated in the meantime |
Contributor
Author
There was a problem hiding this comment.
Because of the await, the session might no longer exist.
lionel-
commented
Dec 4, 2025
| } | ||
|
|
||
| this._lastForegroundSessionId = session.metadata.sessionId; | ||
| await this.activateConsoleSession(session, 'foreground session changed'); |
Contributor
Author
There was a problem hiding this comment.
It looks like multiple activateConsoleSession() might run concurrently if the didChangeForegroundSession event fires rapidly. We might want to queue the handling.
lionel-
force-pushed
the
task/r-session-cleanup
branch
from
26a6c1a to
d87869a
Compare
DavisVaughan
approved these changes
Dec 5, 2025
| await vscode.commands.executeCommand('_extensionTests.setLogLevel', 'trace'); | ||
| // Set global Positron log level to debug on CI for easier debugging | ||
| if (process.env.CI) { | ||
| await vscode.commands.executeCommand('_extensionTests.setLogLevel', 'debug'); |
Contributor
There was a problem hiding this comment.
I think trace was nice?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress towards #10121
Logs involving the session manager are a bit confusing because sessions are never cleaned up, and so the manager keeps trying to deactivate LSP in sessions that no longer exist. This also causes it hold onto
RSessionobjects, preventing garbage collection.To fix this:
RSessiongains aregister()method for external resources that should be cleaned up when the session is disposed of.RSession, instead of the singleton's own disposables.Release Notes
New Features
Bug Fixes
QA Notes
@:ark