Fix packages quick pick to not throw error on cancel#11894
Open
bricestacey wants to merge 2 commits intomainfrom
Open
Fix packages quick pick to not throw error on cancel#11894bricestacey wants to merge 2 commits intomainfrom
bricestacey wants to merge 2 commits intomainfrom
Conversation
When the user cancels the package update or install quick pick, silently do nothing instead of throwing an error. See #11833
|
E2E Tests 🚀 |
austin3dickey
previously approved these changes
Feb 14, 2026
src/vs/workbench/contrib/positronPackages/browser/positronPackagesQuickPick.ts
Outdated
Show resolved
Hide resolved
…agesQuickPick.ts Co-authored-by: Austin Dickey <austin3spammy@gmail.com> Signed-off-by: Brice Stacey <bricestacey@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #11833
Release Notes
When the user cancels the package update or install quick pick, silently do nothing instead of throwing an error. Previously it would throw an error and show an alert dialog. Now, it should do nothing.
New Features
Bug Fixes
QA Notes
Esc