Address feedback on notebook kernel selector race condition fix#12643
Closed
Copilot wants to merge 1 commit intofix/notebook-kernel-selector-race-conditionfrom
Closed
Address feedback on notebook kernel selector race condition fix#12643Copilot wants to merge 1 commit intofix/notebook-kernel-selector-race-conditionfrom
Copilot wants to merge 1 commit intofix/notebook-kernel-selector-race-conditionfrom
Conversation
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on notebook kernel selector race condition fix
Address feedback on notebook kernel selector race condition fix
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback on #12641, which fixed the intermittent "scopedContextKeyService is not available" error by clearing
_scopedContextKeyServiceindetachView().The automated reviewer suggested adding a unit test for the attach/detach lifecycle. After evaluating, no test was added —
_scopedContextKeyService = undefinedfollows the same cleanup pattern already used for_overlayContainerand_notebookOptionsindetachView(), none of which have dedicated tests. A lifecycle test would require significant mock infrastructure and introduce flakiness disproportionate to a one-line change.Release Notes
New Features
Bug Fixes
QA Notes
No behavior change from this PR — it only addresses a code review discussion. Testing guidance is in the original PR #12641.
💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.