-
Notifications
You must be signed in to change notification settings - Fork 121
python: make PET default locator #9111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
E2E Tests 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Small things:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Exciting!
hmmm...with |
Looks like our build process for smoke testing is different than upstream, which mostly is fine but they're specifically putting PET into testing paths in the test itself, where we place PET at build time. Since we run our own e2e tests that have the same functionality, I feel pretty okay skipping these smoke tests and logging turning smoke tests on for later work. Does that sound reasonable? |
In favor of this, thank you! |
Changes from "js" locator to the PET. 🎉
This PR also removes CI runs for upstream smoke tests. This was brought on due to the fact that smoke tests do not run from the expected
positron/extensions/positron-python
directory, so thepet
binary would need to be redownloaded and inserted into the temporary testing path. We have disabled all behavior that is being tested in the smoke tests besides: checking if the LSP is on, running a Python file in the terminal, and checking if Smart Send is on. These are all features that are covered in Positron's own e2e tests. Since the smoke tests are not adding additional coverage or information to our testing suite, we decided to remove them completely.Release Notes
New Features
Bug Fixes
QA Notes
passes CI and if you poke around in different workspaces, Python should be discovered. I don't think we need to add "native" to the e2e settings anymore.