Skip to content

Conversation

isabelizimm
Copy link
Contributor

@isabelizimm isabelizimm commented Aug 20, 2025

Changes from "js" locator to the PET. 🎉

This PR also removes CI runs for upstream smoke tests. This was brought on due to the fact that smoke tests do not run from the expected positron/extensions/positron-python directory, so the pet binary would need to be redownloaded and inserted into the temporary testing path. We have disabled all behavior that is being tested in the smoke tests besides: checking if the LSP is on, running a Python file in the terminal, and checking if Smart Send is on. These are all features that are covered in Positron's own e2e tests. Since the smoke tests are not adding additional coverage or information to our testing suite, we decided to remove them completely.

Release Notes

New Features

Bug Fixes

  • N/A

QA Notes

passes CI and if you poke around in different workspaces, Python should be discovered. I don't think we need to add "native" to the e2e settings anymore.

Copy link

github-actions bot commented Aug 20, 2025

E2E Tests 🚀
This PR will run tests tagged with: @:critical

readme  valid tags

Copy link
Contributor

@austin3dickey austin3dickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Small things:

austin3dickey
austin3dickey previously approved these changes Aug 20, 2025
Copy link
Contributor

@austin3dickey austin3dickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Exciting!

@isabelizimm
Copy link
Contributor Author

hmmm...with "native" as the default, it looks like the upstream smoke tests hang indefinitely. looking into this!

@isabelizimm
Copy link
Contributor Author

isabelizimm commented Aug 20, 2025

Looks like our build process for smoke testing is different than upstream, which mostly is fine but they're specifically putting PET into testing paths in the test itself, where we place PET at build time. Since we run our own e2e tests that have the same functionality, I feel pretty okay skipping these smoke tests and logging turning smoke tests on for later work. Does that sound reasonable?

@jthomasmock
Copy link
Contributor

In favor of this, thank you!

@isabelizimm isabelizimm merged commit 48ed64a into main Aug 20, 2025
30 checks passed
@isabelizimm isabelizimm deleted the use-pet-default branch August 20, 2025 20:50
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants