-
Notifications
You must be signed in to change notification settings - Fork 121
PositroNB: Restart kernel button #9898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
E2E Tests 🚀 |
@seeM Based on your changes, what do you expect to happen in the scenarios 2-4? Cases
Outcomes
|
@seeM Awesome! This is looking good however I am concerned that we are running out of space in the nav bar and not grouping related actions in the same area. I put 2 mockups for exploration here to determine next steps: https://www.figma.com/design/z9EOP4qLLzR08PNxe4M0Ei/Positron-Notebooks---Design-Audit?node-id=305-2&t=8CHFBPPjEQfYYkiB-1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code itself looks great. I'll leave the design part to further discussions.
src/vs/workbench/contrib/runtimeNotebookKernel/browser/runtimeNotebookKernelActions.ts
Outdated
Show resolved
Hide resolved
ca6b680
to
8b66d2d
Compare
Thanks for the reviews! I've updated the UI based on your feedback:
|
@seeM looking great! Based on the design we made the other day with a new dropdown for the kernel, are you suggesting that whole dropdown gets handled in #9722 Where restart kernel and show console would be a submenu item in this dropdown? My understanding was that 9722 would just capture putting the kernel info in the new dropdown |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any particular e2e tests that exercise the notebook kernel restart. I can def add a test for that. However, I was curious if there are any particular checks I should assert? Is there any kind of persistence that is expected or is everything wiped?
@midleman in terms of state, it should behave exactly as restarting a console session. Some ideas:
|
@rodrigosf672 IIUC whether the notebook is saved or not shouldn't affect restart behavior. Perhaps restarting while something is running should display a warning, and perhaps a warning should also be displayed based if data will be lost. Will start a discussion in Slack. |
Add the Restart Kernel button to Positron notebooks, addresses #9789.
Screen.Recording.2025-10-10.at.19.02.37.mov
Release Notes
New Features
Bug Fixes
QA Notes
@:notebooks