Treat tags.script like an HTML dependency inside of JSXTag #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
force-pushed
the
jsx-child-script-tag
branch
from
a458540 to
8168b49
Compare
cpsievert
force-pushed
the
jsx-child-script-tag
branch
from
8168b49 to
bde4d1b
Compare
|
One thing about this that makes me feel like it's not a terrible solution: the way dynamic UI currently renders |
cpsievert
commented
Apr 13, 2022
| # React.createElement("script") won't invoke it's contents in the same | ||
| # way ordinary HTML tags do, but we can circumvent that by 'hoisting' it | ||
| # as head_content. | ||
| metadata_nodes.append(head_content(x)) |
There was a problem hiding this comment.
If we move forward with this, we'll want to have something like head_content(x, dedup=False) to make sure the <script> executes everytime, as it normally would in normal HTML
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26