-
Notifications
You must be signed in to change notification settings - Fork 5
feat(HTML)!: HTML class no longer inherits from str
#86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 47 commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
9117a8a
Expose `ReprHtml` class
schloerke 179f103
Formatting
schloerke 6b28049
`.get_html_string()` now returns `str` instead of `HTML`
schloerke 991852f
Do not support `HTML` for attrs
schloerke 7a2c188
Update `HTML` class to not inherit from `str`
schloerke 0e2ea4b
Update CHANGELOG.md
schloerke ee8b640
Update checkout and setup python to latest versions
schloerke 48037ed
Add job to check dev shiny with pypi & dev htmltools
schloerke 8abe640
TagAttrValue and TagAttrDict now support HTML values
schloerke 372f6b2
Make sure single child HTML or text has no white space around it
schloerke f25ab9c
Loosen type restriction on HTML input object
schloerke 4876bea
bug: Return HTML text when requested
schloerke e6848a2
Fix failing test; JSX tagified should equal itself, now compares stri…
schloerke 9f7bae4
Check dev Shiny w/ dev Htmltools
schloerke 1428c97
Lints
schloerke 05531b7
Use editable install of htmltools; Run tests before checking shiny
schloerke 05bc8da
Add equality method to `HTML`
schloerke b7e2473
Fix bug where html + str resulted in str; Now it returns HTML
schloerke 5e4443d
Update pytest.yaml
schloerke 8d0614c
Do not allow HTML in Tag attrs
schloerke 633466b
Remove `_html_escape` for faicons 0.2.1
schloerke 855e46d
Update CHANGELOG.md
schloerke 6cde017
Merge branch 'main' into html_not_str
schloerke 4e164b1
Use `UserString` as base class for HTML
schloerke 1b658db
lint
schloerke c2d4a58
Add `__radd__()` support for `HTML` to add `HTML()` to `str` objects:…
schloerke 53334c5
Install all of shiny to get the custom version
schloerke 6a094d2
Merge branch 'main' into html_not_str
schloerke 016bc39
Discard changes to .vscode/settings.json
schloerke 75bbd6a
Apply suggestions from code review; Remove unnecessary str calls
schloerke 9ae85d9
Discard changes to htmltools/_util.py
schloerke f67f5dc
Add another breaking change for HTML type addition
schloerke 4ead746
Export `is_tag_node()`, `is_tag_child()` and `consolidate_attrs()`
schloerke 70f4e06
Update CHANGELOG.md
schloerke 19c5eba
`add_style()` added support for receiving `HTML` objects
schloerke 242da23
Use `isinstance(x, ReprHtml)` rather than looking for specific field
schloerke c2cd993
Update test_jsx_tags.py
schloerke d1ea0e0
Allow attr values to be HTML
schloerke 19c4e8c
Move py-shiny testing to it's own job, away from pytest.yaml
schloerke 90c5a84
Use shiny's `ci-install-deps` target to build faster
schloerke 25d5558
Use dev shiny branch for faster debugging
schloerke 3fc4b1c
Update shiny.yaml
schloerke 88e4d78
Update shiny.yaml
schloerke 40b7e1c
Update py-shiny dev branch to main. Use new check action from posit-d…
schloerke 2483d2b
checkout htmltools within _dev/htmltools so that py-shiny checks will…
schloerke 2448ede
auto accept uninstall
schloerke 0d25a1a
Revert TagAttrDict changelog entry about not supporting HTML
schloerke 8e0e26c
Remove outdate changelog
schloerke 7f9bdc6
Apply suggestions from code review
schloerke 86563dc
format comment
schloerke f6badbf
bump dev version to 0.5.3.9001
schloerke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| name: Bleeding Edge Shiny | ||
|
|
||
| on: | ||
| push: | ||
| branches: "shiny-**" | ||
| pull_request: | ||
|
|
||
| jobs: | ||
| htmltools-pr: | ||
| runs-on: ubuntu-latest | ||
| defaults: | ||
| run: | ||
| shell: bash | ||
|
|
||
| steps: | ||
| - name: Checkout py-shiny@main | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| repository: posit-dev/py-shiny | ||
| ref: main | ||
| fetch-depth: 0 # Required for shiny version | ||
| - name: Setup py-shiny@main | ||
| uses: posit-dev/py-shiny/.github/py-shiny/setup@main | ||
| with: | ||
| python-version: "3.12" | ||
|
|
||
| - name: Checkout dev branch of py-htmltools | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| path: _dev/htmltools | ||
|
|
||
| - name: Install dev py-htmltools htmltools dependencies | ||
| run: | | ||
| cd _dev/htmltools | ||
| pip uninstall -y htmltools | ||
| pip install -e ".[dev,test]" | ||
| make install | ||
|
|
||
| - name: Check py-shiny@main | ||
| uses: posit-dev/py-shiny/.github/py-shiny/check@main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.