feat(TagList)!: TagList now inherits from collections.UserList, instead of typing.List
#97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schloerke
force-pushed
the
taglist_not_list
branch
from
119831f to
a277323
Compare
schloerke
force-pushed
the
taglist_not_list
branch
from
a640d32 to
7e3a342
Compare
jcheng5
reviewed
Sep 27, 2024
wch
reviewed
Sep 27, 2024
jcheng5
approved these changes
Sep 27, 2024
…mltools into taglist_not_list
|
No breakages within py-shiny given this PR. Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow for
orjsonto utilize custom printing methods for TagList, rather than waiting until an inner item is printed.Follows similar logic and benefits of #86
Note! Drop support for python 3.8 as python 3.8's
collection.UserListcan not be subscripted toUserList[TagNode]Since we're going to drop 3.8 when 3.13 comes out in early Oct'24, I am not pursuing a fix for 3.8