Skip to content

Conversation

@schloerke
Copy link
Collaborator

@schloerke schloerke commented Sep 11, 2024

Error when trying to run ./examples/airmass/app.py:

    import astropy.units as u
  File "/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/astropy/units/__init__.py", line 23, in <module>
    from .quantity import *
  File "/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/astropy/units/quantity.py", line 36, in <module>
    from .quantity_helper import can_have_arbitrary_unit, check_output, converters_and_unit
  File "/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/astropy/units/quantity_helper/__init__.py", line 16, in <module>
    from . import erfa, function_helpers, helpers, scipy_special
  File "/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/astropy/units/quantity_helper/function_helpers.py", line 79, in <module>
    np.prod, np.product, np.cumprod, np.cumproduct,
  File "/opt/hostedtoolcache/Python/3.9.19/x64/lib/python3.9/site-packages/numpy/__init__.py", line 410, in __getattr__
    raise AttributeError("module {!r} has no attribute "
AttributeError: module 'numpy' has no attribute 'product'

So, disabling test on python 3.9 as it is a smoke test that is covered by other python versions.

astropy is very aggressive on their min python version. Therefore, it is possible to get a not-optimal combination of packages being installed:

  • numpy == 2.0.2
  • astropy == 5.3.2

@schloerke schloerke enabled auto-merge (squash) September 11, 2024 13:10
@schloerke schloerke disabled auto-merge September 11, 2024 21:27
@schloerke
Copy link
Collaborator Author

Goal of PR achieved. CI failures are false-positive

Merging

@schloerke schloerke changed the title test: Add skip for airmass on python 3.9 test: Add skip for airmass example on python 3.9 Sep 11, 2024
@schloerke schloerke merged commit b76a581 into main Sep 11, 2024
47 of 48 checks passed
@schloerke schloerke deleted the fix_numpy_update branch September 11, 2024 21:35
schloerke added a commit that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant