Skip to content

tests(deploys): Move import from htmltools into code to help with debugging deploys #1718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 4, 2024
Merged

tests(deploys): Move import from htmltools into code to help with debugging deploys #1718

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ad81c01
do not install shiny if installing another way
karangattu Oct 4, 2024
25f3cba
Revert "do not install shiny if installing another way"
karangattu Oct 4, 2024
027a498
use dynamic import to get around testing bug
karangattu Oct 4, 2024
c5d4e44
linting issues
karangattu Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion shiny/render/_data_frame_utils/_html.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

from typing import TYPE_CHECKING, Literal, cast, overload

from htmltools import TagNode, is_tag_node
from htmltools import TagNode

from ..._typing_extensions import TypeIs
from ...types import Jsonifiable
Expand Down Expand Up @@ -70,6 +70,8 @@ def ui_must_be_processed(
def ui_must_be_processed( # pyright: ignore[reportInconsistentOverload]
val: object,
):
from htmltools import is_tag_node

if isinstance(val, str):
return False

Expand Down
Loading