Skip to content

Add narwals integration cmd #1729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 10, 2024
Merged

Add narwals integration cmd #1729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4a94c67
Add narwals integration cmd
karangattu Oct 10, 2024
e0c97e3
Merge branch 'main' into add-narwhals-integration-method
schloerke Oct 10, 2024
f3cbb25
Add test for narwhals integration
schloerke Oct 10, 2024
731fd2c
Use UV_SYSTEM_PYTHON env explicitly
schloerke Oct 10, 2024
68086fd
Merge branch 'main' into add-narwhals-integration-method
schloerke Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .github/workflows/pytest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,3 +242,18 @@ jobs:
name: "playright-examples-${{ runner.os }}-${{ matrix.python-version }}-results"
path: test-results/
retention-days: 5

test-narwhals-integration:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Setup py-shiny
id: install
uses: ./.github/py-shiny/setup
- name: Run test
env:
UV_SYSTEM_PYTHON: 1
run: |
make test-narwhals-integration
7 changes: 7 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ SUB_FILE:=
PYTEST_BROWSERS:= --browser webkit --browser firefox --browser chromium
PYTEST_DEPLOYS_BROWSERS:= --browser chromium


# Full test path to playwright tests
TEST_FILE:=tests/playwright/$(SUB_FILE)
# Default `make` values that shouldn't be directly used; (Use `TEST_FILE` instead!)
Expand Down Expand Up @@ -247,3 +248,9 @@ upgrade-html-deps: FORCE ## Upgrade Shiny's HTMLDependencies
exit 1; \
fi
@scripts/htmlDependencies.R

test-narwhals-integration: FORCE
@echo "-------- Install py-shiny ----------"
$(MAKE) ci-install-deps
@echo "-------- Running py-shiny tests ----------"
$(MAKE) test playwright TEST_FILE="tests/playwright/shiny/components/data_frame" PYTEST_BROWSERS="--browser chromium"
Loading