Skip to content

Ignore type error in test introduced by ollama 0.4.2 #1791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Ignore type error in test introduced by ollama 0.4.2 #1791

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbf91ee
Fix type error in test introduced by ollama 0.4.2
cpsievert Dec 4, 2024
d9ff974
Add link to commit
cpsievert Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion tests/pytest/test_chat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,12 @@ def test_as_ollama_message():
import ollama
from ollama import Message as OllamaMessage

assert "ollama._types.Message" in str(ollama.chat.__annotations__["messages"])
# ollama 0.4.2 added Callable to the type hints, but pyright complains about
# missing arguments to the Callable type. We'll ignore this for now.
# https://github.com/ollama/ollama-python/commit/b50a65b
chat = ollama.chat # type: ignore

assert "ollama._types.Message" in str(chat.__annotations__["messages"])

from shiny.ui._chat_provider_types import as_ollama_message

Expand Down
Loading