Skip to content

fix(controllers): use regex pattern that matches any string (including an empty string) #1815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2025
Merged

fix(controllers): use regex pattern that matches any string (including an empty string) #1815

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion shiny/playwright/controller/_input_buttons.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from __future__ import annotations

import pathlib
import re
from typing import Literal, Optional

from playwright.sync_api import FilePayload, Locator, Page
Expand Down Expand Up @@ -61,7 +62,7 @@ def expect_disabled(self, value: bool, *, timeout: Timeout = None):
The maximum time to wait for the expectation to be fulfilled. Defaults to `None`.
"""
_expect_attribute_to_have_value(
self.loc, "disabled", "" if value else None, timeout=timeout
self.loc, "disabled", re.compile(".*") if value else None, timeout=timeout
)


Expand Down
Loading