Skip to content
Merged

Fix CI #1830

Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,10 @@ dev = [
"anthropic",
"google-generativeai;python_version>='3.9'",
"langchain_core",
# Recent versions of langsmith (needed for langchain_core) cause a
# `argparse.ArgumentError` when running `pytest`.
# https://github.com/posit-dev/py-shiny/pull/1830
"langsmith<0.3",
"openai",
"ollama",
"tokenizers",
Expand Down
1 change: 0 additions & 1 deletion shiny/_autoreload.py
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,6 @@ async def process_request(
status_code=http.HTTPStatus.MOVED_PERMANENTLY,
reason_phrase="Moved Permanently",
headers=websockets.Headers(Location=app_url),
body=None,
Copy link
Collaborator Author

@cpsievert cpsievert Jan 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type for body recently went from bytes | None to bytes

python-websockets/websockets@e6d0ea1

It seems we've always just wanted the default value for body anyway, so this seems safe to remove

)
else:
return None
Expand Down
4 changes: 2 additions & 2 deletions tests/pytest/test_chat.py
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ def test_google_normalization():
if sys.version_info < (3, 9):
return

from google.generativeai import ( # pyright: ignore[reportMissingTypeStubs]
from google.generativeai.generative_models import ( # pyright: ignore[reportMissingTypeStubs]
GenerativeModel,
)

Expand Down Expand Up @@ -382,7 +382,7 @@ def test_as_google_message():
if sys.version_info < (3, 9):
return

from google.generativeai import ( # pyright: ignore[reportMissingTypeStubs]
from google.generativeai.generative_models import ( # pyright: ignore[reportMissingTypeStubs]
GenerativeModel,
)

Expand Down
Loading