- 
                Notifications
    You must be signed in to change notification settings 
- Fork 115
          feat: chat.update_user_input() can submit and focus the input
          #1851
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            gadenbuie
  merged 19 commits into
  chat-suggestions-submit
from
chat-suggestions-submit-focus
  
      
      
   
  Feb 13, 2025 
      
    
  
     Merged
                    Changes from 2 commits
      Commits
    
    
            Show all changes
          
          
            19 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      8b7cfb4
              
                refactor: Consolidate into `#applySuggestion()` method
              
              
                gadenbuie 1919558
              
                feat: Expose `submit` and `focus` options in `chat.update_user_input()`
              
              
                gadenbuie 84db0e8
              
                chore: Small refactor
              
              
                gadenbuie a1bbeb3
              
                chore: npm run build
              
              
                gadenbuie 8f78b5b
              
                tests: Add tests for auto-submit and focus
              
              
                gadenbuie 1440d4d
              
                fix: Correctly detect auto-submit with bare `data-suggestion-submit` …
              
              
                gadenbuie fa73d6f
              
                tests: `chat.update_user_input()` with `submit` and `focus`
              
              
                gadenbuie ebfe8ba
              
                docs: Add changelog
              
              
                gadenbuie f47a575
              
                chore: make check
              
              
                gadenbuie 27da819
              
                TEMP: pin pyright <= 1.1.393
              
              
                gadenbuie a057c53
              
                chore: make check-fix with more recent isort
              
              
                gadenbuie 3a7a5d4
              
                Merge branch 'chat-suggestions-submit' into chat-suggestions-submit-f…
              
              
                gadenbuie 7926e66
              
                Revert "TEMP: pin pyright <= 1.1.393"
              
              
                gadenbuie 9d08442
              
                chore: Restore previous value if input value is auto-submitted
              
              
                gadenbuie 10e8b59
              
                chore: Raise error if `submit` or `focus` is `True` but `value` not p…
              
              
                gadenbuie 606a1e0
              
                chore: npm run build
              
              
                gadenbuie ddb9edd
              
                Update test_chat_update_user_input.py
              
              
                gadenbuie 347dd4f
              
                feat(chat): Support input suggestion modifiers (#1854)
              
              
                gadenbuie 4d4788a
              
                docs: submit/focus require value
              
              
                gadenbuie File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Uh oh!
There was an error while loading. Please reload this page.