-
Notifications
You must be signed in to change notification settings - Fork 115
Miscellaneous Chat template improvements
#1872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| # Once you provided your API key, rename this file to .env | ||
| # The load_dotenv() in the app.py will then load this env variable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it'd be good to include this message in the shiny create output. See the template.json in the shiny/templates/apps section for examples. Here's one:
{
"type": "app",
"id": "dashboard",
"title": "Basic dashboard",
"description": "A basic, single page dashboard with value boxes, two plots in cards and a sidebar.",
"next_steps": [
"Run the app with `shiny run app.py`."
],
"follow_up": [
{
"type": "info",
"text": "Just getting started with Shiny?"
},
{
"type": "action",
"text": "Learn more at https://shiny.posit.co/py/docs/user-interfaces.html"
}
]
}There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, forgot that was a thing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great thanks!
| python-dotenv | ||
| tokenizers | ||
| chatlas | ||
| anthropic[bedrock] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note that reading through this PR reminded me of an issue I opened in chatlas to make provider-specific extras in chatlas. Here's the related PR: posit-dev/chatlas#66
In the future (I guess not yet...) it'd be nice to be able to include those extras in these templates -- e.g. chatlas[bedrock-anthropic] -- which would mean that updates to the provider dependencies don't require changes here to stay up-to-date.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, agreed, thanks for the PR
FWIW, tokenizers was once for ui.Chat.messages(token_limits), but we longer advertise it
No description provided.