Skip to content

Conversation

@cpsievert
Copy link
Collaborator

No description provided.

@cpsievert cpsievert added this to the Next Release milestone Feb 26, 2025
@cpsievert cpsievert requested a review from gadenbuie February 26, 2025 15:58
Comment on lines +1 to +2
# Once you provided your API key, rename this file to .env
# The load_dotenv() in the app.py will then load this env variable
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be good to include this message in the shiny create output. See the template.json in the shiny/templates/apps section for examples. Here's one:

{
  "type": "app",
  "id": "dashboard",
  "title": "Basic dashboard",
  "description": "A basic, single page dashboard with value boxes, two plots in cards and a sidebar.",
  "next_steps": [
    "Run the app with `shiny run app.py`."
  ],
  "follow_up": [
    {
      "type": "info",
      "text": "Just getting started with Shiny?"
    },
    {
      "type": "action",
      "text": "Learn more at https://shiny.posit.co/py/docs/user-interfaces.html"
    }
  ]
}

Copy link
Collaborator Author

@cpsievert cpsievert Feb 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, forgot that was a thing!

Copy link
Collaborator

@gadenbuie gadenbuie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks!

python-dotenv
tokenizers
chatlas
anthropic[bedrock]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note that reading through this PR reminded me of an issue I opened in chatlas to make provider-specific extras in chatlas. Here's the related PR: posit-dev/chatlas#66

In the future (I guess not yet...) it'd be nice to be able to include those extras in these templates -- e.g. chatlas[bedrock-anthropic] -- which would mean that updates to the provider dependencies don't require changes here to stay up-to-date.

Copy link
Collaborator Author

@cpsievert cpsievert Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, agreed, thanks for the PR

FWIW, tokenizers was once for ui.Chat.messages(token_limits), but we longer advertise it

@cpsievert cpsievert merged commit ed6cae6 into main Feb 28, 2025
41 checks passed
@cpsievert cpsievert deleted the chat-template-updates branch February 28, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants