Skip to content

Don't apply styling intended for inline text to data-suggestion attribute; better styling for card suggestions #1876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 28, 2025
Merged

Don't apply styling intended for inline text to data-suggestion attribute; better styling for card suggestions #1876

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6bc832e
Don't apply styling intended for inline text to data-suggestion attri…
cpsievert Feb 28, 2025
e33f8df
Don't style card with suggestions inside the card
cpsievert Feb 28, 2025
0eb8dc3
Merge branch 'main' into chat-data-suggestion-styling
cpsievert Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions js/chat/chat.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ shiny-chat-container {
.suggestion,
[data-suggestion] {
cursor: pointer;
}

// Styling for inline-text
.suggestion {
color: var(--bs-link-color, #007bc2);

text-decoration-color: var(--bs-link-color, #007bc2);
Expand Down Expand Up @@ -48,6 +52,13 @@ shiny-chat-container {
}
}
}

// Styling for card suggestions
.card[data-suggestion]:hover,
.card:has([data-suggestion]) {
color: var(--bs-link-color, #007bc2);
border-color: rgba(var(--bs-link-color-rgb), 0.5);
}
}

shiny-chat-messages {
Expand Down
2 changes: 1 addition & 1 deletion shiny/www/py-shiny/chat/chat.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions shiny/www/py-shiny/chat/chat.css.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading