Skip to content

fix(tests): skip modin tests if python version == 3.13 #1882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 6, 2025
Merged

fix(tests): skip modin tests if python version == 3.13 #1882

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d6972b5
skip modin tests if python
karangattu Mar 3, 2025
5c6ec1d
skip two modin tests with reason
karangattu Mar 3, 2025
7e5a6bb
Update tests/playwright/shiny/components/table/test_table.py
karangattu Mar 3, 2025
425ffbf
Update tests/playwright/shiny/components/data_frame/data_type/test_df…
karangattu Mar 3, 2025
b276d57
skip imports for python 3.13
karangattu Mar 4, 2025
432baca
Merge branch 'skip-modin-3.13-tests' of https://github.com/posit-dev/…
karangattu Mar 4, 2025
7527c3a
Merge branch 'bump_versions' into skip-modin-3.13-tests
karangattu Mar 4, 2025
2bc6f8a
Update tests/playwright/shiny/components/data_frame/data_type/app.py
karangattu Mar 4, 2025
3038b72
use approach Winston suggested
karangattu Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/playwright/shiny/components/data_frame/data_type/test_df_data_type.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import re
import sys

import pytest
from playwright.sync_api import Page

from shiny.playwright import controller
Expand Down Expand Up @@ -39,6 +41,10 @@
]


@pytest.mark.skipif(
sys.version_info >= (3, 13),
reason="Skipping on Python 3.13, since modin is not supported on 3.13",
)
def test_data_frame_data_type(
page: Page,
local_app: ShinyAppProc,
Expand Down
6 changes: 6 additions & 0 deletions tests/playwright/shiny/components/table/test_table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,17 @@
import re
import sys

import pytest
from playwright.sync_api import Page

from shiny.playwright import controller
from shiny.run import ShinyAppProc


@pytest.mark.skipif(
sys.version_info >= (3, 13),
reason="Skipping on Python 3.13, since modin is not supported on 3.13",
)
def test_table_data_support(page: Page, local_app: ShinyAppProc) -> None:
page.goto(local_app.url)

Expand Down
Loading