Skip to content

fix(textarea-autoresize): add a bit of padding when setting textarea height #1891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 7, 2025
Merged

fix(textarea-autoresize): add a bit of padding when setting textarea height #1891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
73567d8
fix(textarea-autoresize): add a bit of padding when setting textarea …
cpsievert Mar 6, 2025
56c06ce
Update test expectation
cpsievert Mar 6, 2025
f1351cb
Also get rid of scrollbar on on suggested messages
cpsievert Mar 6, 2025
f7923bc
Update js/chat/chat.scss
cpsievert Mar 7, 2025
f05a8f7
yarn build
cpsievert Mar 7, 2025
b7f1370
Update test expectation
cpsievert Mar 7, 2025
e3c3b8d
Update test expectation
cpsievert Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/chat/chat.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ shiny-chat-container {
text-underline-offset: 4px;
text-decoration-thickness: 2px;

padding: 2px;
padding-inline: 2px;

&:hover {
text-decoration-style: solid;
Expand Down
2 changes: 1 addition & 1 deletion js/text-area/textarea-autoresize.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ function update_height(target: HTMLTextAreaElement) {
if (target.scrollHeight > 0) {
// Automatically resize the textarea to fit its content.
target.style.height = "auto";
target.style.height = target.scrollHeight + "px";
target.style.height = target.scrollHeight + 2 + "px";
} else {
// The textarea is not visible on the page, therefore it has a 0 scroll height.

Expand Down
2 changes: 1 addition & 1 deletion shiny/www/py-shiny/chat/chat.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions shiny/www/py-shiny/chat/chat.css.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion shiny/www/py-shiny/text-area/textarea-autoresize.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ function callUpdateHeightWhenTargetIsVisible(target) {
function update_height(target) {
if (target.scrollHeight > 0) {
target.style.height = "auto";
target.style.height = target.scrollHeight + "px";
target.style.height = target.scrollHeight + 2 + "px";
} else {
callUpdateHeightWhenTargetIsVisible(target);
}
Expand Down
8 changes: 4 additions & 4 deletions tests/playwright/shiny/inputs/input_text_area/autoresize/test_accordion_autoresize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ def test_accordion(page: Page, local_app: ShinyAppProc, is_webkit: bool) -> None
# Skip the rest of the test for webkit.
# Heights are not consistent with chrome and firefox
return
expect_to_have_style(test_text_area.loc, "height", "125px")
expect_to_have_style(test_text_area_w_rows.loc, "height", "125px")
expect_to_have_style(test_text_area.loc, "height", "127px")
expect_to_have_style(test_text_area_w_rows.loc, "height", "127px")

# Make sure the `rows` is consistent
test_text_area.expect_rows("1")
Expand All @@ -42,6 +42,6 @@ def test_accordion(page: Page, local_app: ShinyAppProc, is_webkit: bool) -> None
test_text_area_w_rows.set("single row")

# 1 row
expect_to_have_style(test_text_area.loc, "height", "35px")
expect_to_have_style(test_text_area.loc, "height", "37px")
# 4 rows
expect_to_have_style(test_text_area_w_rows.loc, "height", "102px")
expect_to_have_style(test_text_area_w_rows.loc, "height", "104px")
Loading