Skip to content

chore: Add support for Narwhals Time dtype in serialize_dtype #1892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 10, 2025
Merged

chore: Add support for Narwhals Time dtype in serialize_dtype #1892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62c8933
chore: Add support for Narwhals Time dtype in serialize_dtype
FBruzzesi Mar 7, 2025
d3bf198
Safeguard attr access
schloerke Mar 10, 2025
40a2f62
typing updates
schloerke Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions shiny/render/_data_frame_utils/_tbl_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,12 @@ def serialize_dtype(col: nw.Series) -> FrameDtype:
type_ = "datetime"
elif isinstance(dtype, nw.Duration):
type_ = "duration"
elif hasattr(nw, "Time") and isinstance(
dtype,
# https://github.com/narwhals-dev/narwhals/pull/2113
nw.Time, # pyright: ignore[reportUnknownMemberType,reportAttributeAccessIssue]
):
type_ = "time"
elif isinstance(dtype, nw.Object):
type_ = "object"
if series_contains_htmltoolslike(col):
Expand Down
1 change: 1 addition & 0 deletions shiny/render/_data_frame_utils/_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,7 @@ class FrameDtypeSubset(TypedDict):
"boolean",
"date",
"datetime",
"time",
"duration",
"object",
"unknown",
Expand Down
Loading