Update shiny TS types to Shiny 1.10.0 #1893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wch
force-pushed
the
update-shinyjs-types
branch
from
aa24e14 to
db4ad56
Compare
schloerke
approved these changes
Mar 11, 2025
schloerke
added a commit
that referenced
this pull request
Mar 11, 2025
* main: chore: Use details for extra info from error message (#1903) ci: adds action to lint conventional commits (#1902) build: JS build script updates (#1894) chore: Rename temp environ names (for launching browser) to avoid conflict with local environ names (#1899) build: Update shiny TS types to Shiny 1.10.0 (#1893) chore: Use `shiny.module` to import re-exported values from `shiny._namespaces` (#1898)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the TypeScript types to Shiny 1.10.0, to be in sync the version of shiny.js that we use.
I also changed the references from
Shinytowindow.Shiny, in keeping with the practice inside the Shiny Typescript source code. See: rstudio/shiny#4197 (comment)This also removes unneeded use of
$(function() { .... }), where just running the....would suffice. For example, this code:becomes just
This is OK because by the time any of this code runs, the
Shinyobject is already available. If there is code that needed to wait for the session to be initialized, then it originally would have had$(document).on('shiny:sessioninitialized', ...), orShiny.initializedPromise.then(...)(which was available as of shiny.js 1.9.0) -- but there were no such instances in the code.