fix(Chat)!: Move away from inheriting from TypedDict for internal Chat classes #1897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
force-pushed
the
chat-class-types
branch
3 times, most recently
from
4b1e04e to
2f3e36c
Compare
gadenbuie
reviewed
Mar 11, 2025
cpsievert
force-pushed
the
chat-class-types
branch
from
3bc17be to
ea83a33
Compare
cpsievert
changed the title
cpsievert
force-pushed
the
chat-shiny-bind
branch
from
d9cdeee to
2f46b2c
Compare
cpsievert
force-pushed
the
chat-class-types
branch
from
d9a1093 to
b003046
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1868 (comment)
Note also this branches off of #1868