- 
                Notifications
    
You must be signed in to change notification settings  - Fork 115
 
          feat(Chat): Add .message_stream_context()
          #1906
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from 19 commits
      Commits
    
    
            Show all changes
          
          
            26 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      916d2c0
              
                feat(Chat): Add .start_message_stream(), .end_message_stream(), and .…
              
              
                cpsievert 4c32a0d
              
                Go back to a more minimal change
              
              
                cpsievert 81a99d2
              
                Cleanup
              
              
                cpsievert 08c104a
              
                Polish API and clarify behavior
              
              
                cpsievert edc30f0
              
                Fix test
              
              
                cpsievert 28f148f
              
                Merge branch 'main' into chat-inject-stream
              
              
                cpsievert 648d9cc
              
                wip first pass at properly nested streams
              
              
                cpsievert 3786b79
              
                Support nested streams and simplify logic
              
              
                cpsievert 260f902
              
                .append_message() should also queue when a stream is active
              
              
                cpsievert bd6d40f
              
                Fix/simplify transform logic
              
              
                cpsievert 0c2e9ec
              
                Reduce diff
              
              
                cpsievert 0cb99aa
              
                Merge branch 'main' into chat-inject-stream
              
              
                cpsievert a05b447
              
                Update test
              
              
                cpsievert bb171f7
              
                Yield a MessageStream() instance with a .append() and .restore() method
              
              
                cpsievert 5e822fc
              
                Cut public .append_message_chunk() method; rename context manager method
              
              
                cpsievert 24f05e5
              
                Improve docstring
              
              
                cpsievert 4995ade
              
                More complete playwright test
              
              
                cpsievert 3c0ca35
              
                Merge branch 'main' into chat-inject-stream
              
              
                cpsievert 7ac2ba1
              
                Rename append_message_context() -> message_stream_context()
              
              
                cpsievert f8ff425
              
                Rename .restore() -> .clear()
              
              
                cpsievert f46aaf8
              
                Merge branch 'main' into chat-inject-stream
              
              
                cpsievert 0ffdf21
              
                Update changelog
              
              
                cpsievert 35837bc
              
                Merge branch 'main' into chat-inject-stream
              
              
                cpsievert c9fad38
              
                Drop .clear() method in favor of replace
              
              
                cpsievert bd5e610
              
                Rename test files
              
              
                cpsievert 2a6d934
              
                Include the operation when queueing message chunks
              
              
                cpsievert File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're not going to use the term "checkpoint" then I think this should be
msg.clear(). What do you think?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, that is better, thanks 👍