Skip to content

fix(session): Always have calling session be the parent session when making a scoped session #1923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 17, 2025
Merged

fix(session): Always have calling session be the parent session when making a scoped session #1923

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06d8f1a
When making scope, always have calling session be the parent
schloerke Mar 17, 2025
1879624
Update CHANGELOG.md
schloerke Mar 17, 2025
4483623
Disable broken test
schloerke Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

* Fixed an issue with the `.click()` method on InputActionButton controllers in `shiny.playwright.controllers` where the method would not work as expected. (#1886)

* Fixed an issue where the parent session of a nested module's session was not being set to the calling session. Now, a session who's namespace is `A-B` has a parent of `A` and grandparent of `(root)` (whereas before it would have skipped `A` and the parent would have been `(root)`). (#1923)


## [1.3.0] - 2025-03-03

### New features
Expand Down
5 changes: 3 additions & 2 deletions shiny/session/_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1233,8 +1233,9 @@ def is_stub_session(self) -> bool:
async def close(self, code: int = 1001) -> None:
await self._parent.close(code)

def make_scope(self, id: str) -> Session:
return self._parent.make_scope(self.ns(id))
def make_scope(self, id: Id) -> Session:
ns = self.ns(id)
return SessionProxy(parent=self, ns=ns)

def root_scope(self) -> Session:
res = self
Expand Down
Loading