chore(session): Rename ._parent to ._root_session in Session classes
#1925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oxy_session` where applicable
schloerke
changed the title
._parent to ._root_session in Session objects._parent to ._root_session in Session objects
schloerke
changed the title
._parent to ._root_session in Session objects._parent to ._root_session in Session classes
There was a problem hiding this comment.
Pull Request Overview
This PR renames the internal variable from "._parent" to "._root_session" in Session classes and applies similar changes in Bookmark classes to improve naming consistency.
- Updated construction of SessionProxy by replacing the "parent" parameter with "root_session"
- Adjusted attribute names and method calls in BookmarkApp and BookmarkProxy to use the new "root_session" naming
- Revised SessionProxy implementation in the session module accordingly
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| shiny/express/_stub_session.py | Updated make_scope to use "root_session=self" when instantiating SessionProxy |
| shiny/bookmark/_bookmark.py | Renamed variables and updated references from _session to _root_session in Bookmark classes |
| shiny/session/_session.py | Modified SessionProxy to use "root_session" instead of "parent" and updated relevant calls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #1924 (comment)
Also apply to
Bookmarkclasses