fix(Chat, MarkdownStream): prevent escaping of HTML inside message content strings #1939
+21
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1868. That PR introduced a problem where HTML content included in a starting message no longer rendered as HTML since the HTML started getting escaped. For a reprex, this example:
Went from:
to:
Note that:
append_message()et al. since we're already skipping the "tagify" step there for strings.