Skip to content

Conversation

@schloerke
Copy link
Collaborator

This PR is currently a POC w/ an example app.

Features:

  • Added on_session_disconnect() that accepts a URL and immediately sends it to the browser.

@schloerke
Copy link
Collaborator Author

This method requires constant creation of the bookmark URL within the server to function as a last resort within the browser.

I believe this it is the worst of all bookmarking worlds.

If the user refreshes their page, they do not get the behavior. They only get a bookmarked site if the server has an error or the server session times out. If the user performs any bookmarkable state action, their URL bar is not updated.

Since the user is constantly creating bookmark URLs, the server will create many bookmark folders that the user can not utilize.


I'm going to close this PR as I can't defend the final outcome.

@schloerke schloerke closed this Apr 8, 2025
@schloerke schloerke deleted the bookmark_on_session_end branch April 8, 2025 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants