Skip to content

fix: Expanding timeout test #2006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 4, 2025
Merged

fix: Expanding timeout test #2006

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6cbca78
Expanding timeout test
elnelson575 Jun 4, 2025
dea85c8
Making the timeout even longer
elnelson575 Jun 4, 2025
7e108cd
Adding even more time
elnelson575 Jun 4, 2025
6206ae0
Updating timeout
elnelson575 Jun 4, 2025
852606f
Adjust timing
elnelson575 Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions tests/playwright/shiny/components/MarkdownStream/basic/test_stream_basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,21 +29,21 @@ def test_validate_stream_basic(page: Page, local_app: ShinyAppProc) -> None:
page.goto(local_app.url)

stream = page.locator("#shiny_readme")
expect(stream).to_be_visible(timeout=30 * 1000)
expect(stream).to_contain_text("pip install shiny")
expect(stream).to_be_visible(timeout=30_000)
expect(stream).to_contain_text("pip install shiny", timeout=30_000)

# Check that the card body container (the parent of the markdown stream) is scrolled
# all the way to the bottom
is_scrolled = is_element_scrolled_to_bottom(page, ".card-body")
assert is_scrolled, "The card body container should be scrolled to the bottom"

stream2 = page.locator("#shiny_readme_err")
expect(stream2).to_be_visible(timeout=30 * 1000)
expect(stream2).to_contain_text("Shiny")
expect(stream2).to_be_visible(timeout=30_000)
expect(stream2).to_contain_text("Shiny", timeout=30_000)

notification = page.locator(".shiny-notification-error")
expect(notification).to_be_visible(timeout=30 * 1000)
expect(notification).to_contain_text("boom!")
expect(notification).to_be_visible(timeout=30_000)
expect(notification).to_contain_text("boom!", timeout=30_000)

txt_result = controller.OutputText(page, "stream_result")
txt_result.expect_value("Stream result: Basic stream")
Loading